@henningw - these seem to be completely new variables, returning the full certificate in escaped format. The transformation would help if there would be variables returning the full certificate in unescaped format. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2268#issuecomment-606449694

Thanks, this sounds good. It is probably better to use a generic approach with an existing transformation than to add new PVs for special cases. In case a PV with a certain transformation is needed frequently, it can be still added, thought. I was just not sure if this is the case here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2268#issuecomment-606809674

I just pushed an amended commit for these 4 variables and their accompanying selects: $tls_{peer,my}_{raw,urlencoded}_cert. The commit was amended to correct the variable description. Note that I changed "escaped" to "urlencoded" since it is more specific in what type of escaping mechanism is being used. @miconda @henningw please let me know what you think. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2268#issuecomment-607589106

Merged #2268 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2268#event-3201479671

@armenb - there were some warnings that I got in macos compilation: ``` CC (gcc) [M tls.so] tls_select.o tls_select.c:765:7: warning: variable 'local' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case CERT_URLENCODED: urlencoded = 1; break; ^~~~~~~~~~~~~~~ tls_select.c:771:27: note: uninitialized use occurs here return get_ssl_cert(res, local, urlencoded, msg); ^~~~~ tls_select.c:764:7: warning: variable 'local' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case CERT_RAW: urlencoded = 0; break; ^~~~~~~~ tls_select.c:771:27: note: uninitialized use occurs here return get_ssl_cert(res, local, urlencoded, msg); ^~~~~ tls_select.c:759:11: note: initialize the variable 'local' to silence this warning int local, urlencoded; ^ = 0 tls_select.c:763:7: warning: variable 'urlencoded' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case CERT_LOCAL: local = 1; break; ^~~~~~~~~~ tls_select.c:771:34: note: uninitialized use occurs here return get_ssl_cert(res, local, urlencoded, msg); ^~~~~~~~~~ tls_select.c:762:7: warning: variable 'urlencoded' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case CERT_PEER: local = 0; break; ^~~~~~~~~ tls_select.c:771:34: note: uninitialized use occurs here return get_ssl_cert(res, local, urlencoded, msg); ^~~~~~~~~~ tls_select.c:759:23: note: initialize the variable 'urlencoded' to silence this warning int local, urlencoded; ^ = 0 ``` I pushed a patch to initialize the variables: * https://github.com/kamailio/kamailio/commit/e2be8fe723ab98318816c18b59ffd08… But my guess that local and urlencoded have to be used as a combination, with both set, not only one set as it seems to be done in that switch. You know better the related code, check the commit and see if anything else needs to be done. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2268#issuecomment-609935161