5 Oct
2021
5 Oct
'21
3:07 p.m.
Anchors like ^ and $ match beginning resp. ending of strings but their
matches are zero length, which is ok.
The anchors can be used to pre-/append a prefix/suffix via e.g.
subst_hf("X-My-Header", "/^/prefix /",
"a");
subst_hf("X-My-Header", "/$/ suffix/",
"a");
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x
...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes
that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines
from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on
sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that
apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2869
-- Commit Summary --
* <a
href="https://github.com/kamailio/kamailio/pull/2869/commits/63190fb0f…quot;>core:
allow empty matches</a>
-- File Changes --
M src/core/data_lump.c (2)
M src/core/re.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2869.patch
https://github.com/kamailio/kamailio/pull/2869.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2869
5 Oct
5 Oct
4:53 p.m.
Patch is small, but I wonder what side effects it can bring to existing configs, this
behaviour likely is there for almost 2 decades. Maybe a global param can be added to
control it. Any other opinions?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2869#issuecomment-934338796
4:58 p.m.
Yes, i also think it should be probably configurable, and probably default deactivated. If
there is another way of achieving this (for example in the textops module, maybe this is
an even better way instead of adding another core parameter and code path.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2869#issuecomment-934341967
7 Dec
7 Dec
6:09 p.m.
@btriller - looking again at this one, wouldn't it be the same to do:
```
subst_hf("X-My-Header", "/^(.+)$/prefix \1/", "a");
subst_hf("X-My-Header", "/^(.+)$/\1 suffix/", "a");
```
instead of:
```
subst_hf("X-My-Header", "/^/prefix /", "a");
subst_hf("X-My-Header", "/$/ suffix/", "a");
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2869#issuecomment-987910682
6:12 p.m.
And as another idea, maybe adding new functions like suffix_hf()/prefix_hf() would be even
better, not to rely on regex matching for these basic operation.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2869#issuecomment-987913283
7:09 p.m.
@btriller - looking again at this one, wouldn't it
be the same to do:
```
subst_hf("X-My-Header", "/^(.+)$/prefix \1/", "a");
subst_hf("X-My-Header", "/^(.+)$/\1 suffix/", "a");
```
instead of:
```
subst_hf("X-My-Header", "/^/prefix /", "a");
subst_hf("X-My-Header", "/$/ suffix/", "a");
```
Knowing that
```
% echo blub|sed 's/^/prefix /'
prefix blub
% echo blub|sed 's/$/ suffix/'
blub suffix
```
works, it felt weird to write
```
subst_hf("X-My-Header", "/^(.)/prefix \1/", "a");
subst_hf("X-My-Header", "/(.)$/\1 suffix/", "a");
```
As most of the time, there are other ways to do it (above suggested or `remove_hf()`,
looping over all headers and `append_hf()`).
I understand the concerns, so I don't mind if the PR is closed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2869#issuecomment-987959909
9:33 p.m.
Closing it then, in this form it changes how it used to work so far.
You can propose another PR that makes this new behaviour configurable or adds new
functions to offer the functionality.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2869#issuecomment-988087266
9:33 p.m.
Closed #2869.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2869#event-5728741305
890
days inactive
953
days old
7 comments
3 participants
participants (3)
-
Bastian Triller -
Daniel-Constantin Mierla
-
Henning Westerholt