[kamailio/kamailio] ims_registrar_scscf: fix memleaks, minor refactors (PR #3787)
<!-- Kamailio Pull Request Template --> <!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception --> #### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description A couple small changes to the ims_registrar_scscf which prevents kamailio from crashing on my system. I would love to have more testing because I only did tests in my single user IMS setup. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3787 -- Commit Summary -- * ims_registrar_scscf: fix uninitialized arguments in save() * ims_registrar_scscf: refactor save_fixup4 * ims_registrar_scscf: fix typo in function name uint_fixup * ims_registrar_scscf: free_uint_fixup: fix memleak/freeing the wrong parameter -- File Changes -- M src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c (55) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3787.patch https://github.com/kamailio/kamailio/pull/3787.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3787 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3787@github.com>
This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3787#issuecomment-2080329029 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3787/c2080329029@github.com>
Thanks for the PR, it will be merged in the next days if there are no more comments. Regarding further cleanups, it probably should also be investigated if we can replace the uint_fixup with some standard fixup from the core. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3787#issuecomment-2082269187 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3787/c2082269187@github.com>
Looks ok for merging, imo. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3787#issuecomment-2082732228 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3787/c2082732228@github.com>
Merged #3787 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3787#event-12646570767 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3787/issue_event/12646570767@github.com>
Thanks again, merged -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3787#issuecomment-2083271557 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3787/c2083271557@github.com>
participants (4)
-
Alexander Couzens -
Daniel-Constantin Mierla -
github-actions[bot] -
Henning Westerholt