21 Jan
2010
21 Jan
'10
4:37 p.m.
Hi!
The sr/ser/kamailio smaple configs contain:
if (!t_relay()) {
sl_reply_error();
}
I wonder if this is still the case. I did some TCP tests and when the
TCP forwarding fails (e.g. RST received or set_forward_no_connect()
activated), then tm module itself replies stateful with 477 and then
returning to script with FALSE. Thus, sl_reply_error will send 500
response stateless too.
IMO if tm module already sent a final response, it should exit without
entering script again.
Even better would be to reply only if there is no failure route sent.
Further, if TCP forwarding fails due to set_forward_no_connect() it logs:
ERROR: tm [../../forward.h:169]: msg_send: ERROR: tcp_send failed
ERROR: tm [t_fwd.c:1235]: ERROR: t_send_branch: sending request on
branch 0 failed
IMO it would be good to log this only with L_INFO, as it is not an
error, but intended behavior.
Thanks
Klaus
23 Jan
23 Jan
4:49 a.m.
i have also been struggling with this and very much would like to see a
clarification to the issues raised by klaus.
-- juha
--------------------------------------------------------------------
Klaus Darilion writes:
Hi!
The sr/ser/kamailio smaple configs contain:
if (!t_relay()) {
sl_reply_error();
}
I wonder if this is still the case. I did some TCP tests and when the
TCP forwarding fails (e.g. RST received or set_forward_no_connect()
activated), then tm module itself replies stateful with 477 and then
returning to script with FALSE. Thus, sl_reply_error will send 500
response stateless too.
IMO if tm module already sent a final response, it should exit without
entering script again.
Even better would be to reply only if there is no failure route sent.
Further, if TCP forwarding fails due to set_forward_no_connect() it logs:
ERROR: tm [../../forward.h:169]: msg_send: ERROR: tcp_send failed
ERROR: tm [t_fwd.c:1235]: ERROR: t_send_branch: sending request on
branch 0 failed
IMO it would be good to log this only with L_INFO, as it is not an
error, but intended behavior.
Thanks
Klaus
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
25 Jan
25 Jan
3:29 a.m.
Klaus Darilion writes:
IMO if tm module already sent a final response, it
should exit without
entering script again.
exiting is not a good idea, because in case of t_relay failure, some
cleanup actions may need to be done in the script, for example,
releasing media session. better to never sent final response
automatically.
-- juha
27 Jan
27 Jan
8:38 a.m.
Juha Heinanen schrieb:
Klaus Darilion writes:
Agreed.
IMO if tm module already sent a final response,
it should exit without
entering script again.
exiting is not a good idea, because in case of t_relay failure, some
cleanup actions may need to be done in the script, for example,
releasing media session. better to never sent final response
automatically. 
11:31 a.m.
On Jan 21, 2010 at 17:37, Klaus Darilion <klaus.mailinglists(a)pernau.at> wrote:
Hi!
The sr/ser/kamailio smaple configs contain:
if (!t_relay()) {
sl_reply_error();
}
I wonder if this is still the case. I did some TCP tests and when the
TCP forwarding fails (e.g. RST received or set_forward_no_connect()
activated), then tm module itself replies stateful with 477 and then
returning to script with FALSE. Thus, sl_reply_error will send 500
response stateless too.
t_relay() will return error if it fails to create a transaction
(unlikely, only on out-of-mem), send failed on all branches (your case),
cancel failed or stateless ACK forwarding failed.
tm will send an error reply only if no other statefull reply (t_reply()) is
sent in the script.
One way to handle this from the script is first to try t_reply() and
only if t_reply() fails, sl_reply_error(). E.g.:
if (!t_relay()){
if (!t_reply("500", "Some error"))
sl_reply_error();
}
Another possible way:
if (!t_relay()){
if (t_lookup_request())
exit; # transaction exists -> exit to trigger the auto-reply
else
sl_reply_error();
}
You could also use t_newtran(). If t_newtran() fails => sl_reply(). If
it doesn't and t_relay() fails => t_reply() let tm generate the reply.
IMO if tm module already sent a final response, it should exit without
entering script again.
tm sends a final response only at the end of the script and only no
other reply was sent from the script via t_reply. This allows overriding
the final reply from the script.
Even better would be to reply only if there is no failure route sent.
Further, if TCP forwarding fails due to set_forward_no_connect() it logs:
ERROR: tm [../../forward.h:169]: msg_send: ERROR: tcp_send failed
ERROR: tm [t_fwd.c:1235]: ERROR: t_send_branch: sending request on
branch 0 failed
IMO it would be good to log this only with L_INFO, as it is not an
error, but intended behavior.
Agreed, but is quite hard to propagate the reason for the send failure
back to tm.
Andrei
11:44 a.m.
Andrei Pelinescu-Onciul schrieb:
On Jan 21, 2010 at 17:37, Klaus Darilion
<klaus.mailinglists(a)pernau.at> wrote:
Is it also possible to t_relay the call a second time? For example
relaying failed as the destination SIP proxy is not available can I
redirect the call to an announcement server? e.g.:
if (!t_relay()){
if (t_lookup_request())
$du = "sip:announcement01@1.2.3.4";
t_relay();
exit;
else
sl_reply_error();
}
regards
Klaus
Hi!
The sr/ser/kamailio smaple configs contain:
if (!t_relay()) {
sl_reply_error();
}
I wonder if this is still the case. I did some TCP tests and when the
TCP forwarding fails (e.g. RST received or set_forward_no_connect()
activated), then tm module itself replies stateful with 477 and then
returning to script with FALSE. Thus, sl_reply_error will send 500
response stateless too.
t_relay() will return error if it fails to create a transaction
(unlikely, only on out-of-mem), send failed on all branches (your case),
cancel failed or stateless ACK forwarding failed.
tm will send an error reply only if no other statefull reply (t_reply()) is
sent in the script.
One way to handle this from the script is first to try t_reply() and
only if t_reply() fails, sl_reply_error(). E.g.:
if (!t_relay()){
if (!t_reply("500", "Some error"))
sl_reply_error();
}
Another possible way:
if (!t_relay()){
if (t_lookup_request())
exit; # transaction exists -> exit to trigger the auto-reply
else
sl_reply_error();
}
You could also use t_newtran(). If t_newtran() fails => sl_reply(). If
it doesn't and t_relay() fails => t_reply() let tm generate the reply.
IMO if tm module already sent a final response,
it should exit without
entering script again.
tm sends a final response only at the end of the script and only no
other reply was sent from the script via t_reply. This allows overriding
the final reply from the script.
Even better would be to reply only if there is no
failure route sent.
Further, if TCP forwarding fails due to set_forward_no_connect() it logs:
ERROR: tm [../../forward.h:169]: msg_send: ERROR: tcp_send failed
ERROR: tm [t_fwd.c:1235]: ERROR: t_send_branch: sending request on
branch 0 failed
IMO it would be good to log this only with L_INFO, as it is not an
error, but intended behavior.
Agreed, but is quite hard to propagate the reason for the send failure
back to tm.
Andrei
12:02 p.m.
On Jan 27, 2010 at 12:44, Klaus Darilion <klaus.mailinglists(a)pernau.at> wrote:
[..]
Is it also possible to t_relay the call a second time? For example
relaying failed as the destination SIP proxy is not available can I
redirect the call to an announcement server? e.g.:
if (!t_relay()){
if (t_lookup_request())
$du = "sip:announcement01@1.2.3.4";
t_relay();
exit;
else
sl_reply_error();
}
Yes, but only if you use append_branch() before t_relay(). t_relay()
uses the request uri only when it is called for the first time.
Subsequent invocation look to see if more branches are appended (if not
they report an error).
Andrei
5220
days inactive
5226
days old
6 comments
3 participants
participants (3)
-
Andrei Pelinescu-Onciul -
jh＠tutpro.com -
Klaus Darilion