Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: sec-agree implementation for IMS (#1605)

Hello Henning, Thanks for your comments. I've removed the README, however, the copyright/licensing part is a bit complicated for me. I have copied code from ims_registrar_pcscf for things like module structure and finding the contact in memory, etc. I've used the implementation in OpenIMS mainly as a reference - what functions they expose to the routing logic and how they use internal Kamailio structures to redirect SIP messages. The IPSec handling itself is written from scratch because they used shell scripts, instead of netlink sockets. For there reasons I copied the Copyright notice from ims_registrar_pcscf (which is actually the same as in OpenIMSCore) and put it in the sources, based on other's work. Everything else is in GPLv2. Do you feel this is correct or it's better to put OpenIMSCore's copyright everywhere? In general, all I want is to contribute the code back to the project and not to abuse the licensing. I don't care if my name will stay anywhere or not. Best regards, Tsvetomir -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1605#issuecomment-408780215