Re: [sr-dev] [kamailio/kamailio] keepalive: fix initialization when using destination mod param (#2579)

@NGSegovia commented on this pull request. + new_destination->uri.s = shm_malloc(sizeof(char) * strlen(uri)); + new_destination->owner.s = shm_malloc(sizeof(char) * strlen(owner)); + + memcpy(new_destination->uri.s, uri, strlen(uri)); + new_destination->uri.len = strlen(uri); + + memcpy(new_destination->owner.s, owner, strlen(owner)); + new_destination->owner.len = strlen(owner); + + new_destination->next = NULL; + + if (ka_initial_destinations_list == NULL) { + ka_initial_destinations_list = new_destination; + } else { + ka_initial_dest_t *current_position = ka_initial_destinations_list; Is there any programming style recommendation? I'm sorry to disagree here but some code checkers may complain about that saying "The scope of the variable 'x' can be reduced" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2579#discussion_r541016309