21 Jul
2016
21 Jul
'16
4:40 a.m.
I am fine with either or even none.
It was though quite nasty to find a few days ago the create statements for something
standard and simple like the pua module.The README said "The SQL syntax to create it
can be found in presence_xml-create.sql script in the database directories in the
kamailio/scripts folder." Yeah, right :). I ended up digging through very old history
to find where that file went missing. Then I manually patched and extended it to match
what the code was using. And now I still don't have the indices...
In Wharf/OpenEPC we have yet another policy, which seems to work though - every module
that uses a DB must have a directory "sql" inside the module that contains the
said structures. I know that this combines code with SQL, bash scripts and other things,
but IMO it is better to have all related things localized than spread around and lost
eventually.
So while the examples dir is nice, the issues with it is that it gets too disconnected
from the actual code. If things are closer-by, then devs have no excuse that they forgot
to patch-in a new column in the DB, or a new parameter in the example config. Anyway, just
my 2 cents, I don't want to make big waves for this little thing and waste your time.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/718#issuecomment-234192217