Re: [sr-dev] [kamailio/kamailio] ims_usrloc_pcscf: implementation of db_mode DB_ONLY (value 3) (PR #3279)

Thanks for the contribution. At first review, I did see a few topics: - please update the XML for the documentation (in the doc/ folder) not the README directly - it would get overwritten, since it is autogenerated - please make sure to add documentation (in the XML) for the new parameters introduced, in the README only the DB-Mode was added, not the other two new parameters - instead of commenting code, please remove code. GIT will keep the history, no need to comment I am no angel myself regarding documentation, but please make sure to keep up with certain standards. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3279#issuecomment-1308982186 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3279/c1308982186(a)github.com>