Re: [sr-dev] dispatcher: limit a number of dst to failover to

Hello, thanks for sending the patch! Two remarks for now: 1) you changed the inter-module API prototype for ds_select_dst_f, respectively: typedef int (*ds_select_dst_f)(struct sip_msg *msg, int set, - int alg, int mode); + int alg, unsigned int limit, int mode); I think the reason for that function is an export to app_lua (and maybe other embedded languages). With this change, things get broken there. I would do: - rename the function ds_select_dst() to ds_select_dst_limit() - add ds_select_dst() as a wrapper function calling the new ds_select_dst_limit() The API stay unchanged, and eventually one can add a new member for ds_select_dst_limit() when needed Otherwise, the change of ds_select_dst() prototype should involve reviewing other modules and seeing if people are happy with this change, because it breaks existing embedded scripts. 2) You need to document the new functions exported to kamailio config, in modules/dispatcher/doc/dispatcher_admin.xml Once the patch is overall ok, I can commit it to the repository. Cheers, Daniel On 21/08/14 17:40, Alekzander Spiridonov wrote: -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Next Kamailio Advanced Trainings 2014 - http://www.asipto.com Sep 22-25, Berlin, Germany ::: Oct 15-17, San Francisco, USA