Re: [sr-dev] [kamailio/kamailio] rtp_media_server: adding module (#1701)

jchavanton commented on this pull request.

+// https://tools.ietf.org/html/rfc4566 +// (protocol version) +const char *sdp_v = "v=0\r\n"; +// (session name) +const char *sdp_s = "s=-\r\n"; +// (time the session is active) +const char *sdp_t = "t=0 0\r\n"; +//"a=rtpmap:101 telephone-event/8000\r\n" +//"a=fmtp:101 0-15\r\n"; +//"a=rtpmap:0 PCMU/8000\r\n" +//"a=rtpmap:8 PCMA/8000\r\n" +//"a=rtpmap:96 opus/48000/2\r\n" +//"a=fmtp:96 useinbandfec=1\r\n"; + +static char *rms_shm_strdup(char *source)

The reason is that shm_str_dup does not garanty terminated 'char*', this is one less thing to worry about. The module is not trying to optimize string like Kamailio is when parsing messages.