[sr-dev] Re: [kamailio/kamailio] cdp: add TLS capability (PR #3548)

I think the TLS implementation for SIP can't be used in this module, because the cdp module has its own internal design with dedicated transport workers. Reusing some common functions could be eventually done, but I am not sure how much code is shared in the current approach. The tls config parser is anyhow the ini-parser from core, it is not inside the tls module. At this moment I don't see a straightforward way that having/adding support for a TLS version (say TLS 1.3) in one module becomes available in the other one. For the moment, the current implementation might have to be merged as it is, future reworking might do a better code sharing. As a generic note, the name of the function does not have to be explicitly added to the log messages, it is done automatically for all log messages -- it might be that CDP module was not updated to remove function names from old log messages, but the new ones should avoid having function names, they will appear twice. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3548#issuecomment-1691556779 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3548/c1691556779(a)github.com>