[sr-dev] git:master:74847c38: core: better protection against invalid name lookup in DNS caching support

Module: kamailio Branch: master Commit: 74847c386f627ba89a0cb282e85d653388d45e24 URL: https://github.com/kamailio/kamailio/commit/74847c386f627ba89a0cb282e85d653… Author: Henning Westerholt &lt;hw(a)kamailio.org&gt; Committer: Henning Westerholt &lt;hw(a)kamailio.org&gt; Date: 2018-06-17T17:13:51+02:00 core: better protection against invalid name lookup in DNS caching support --- Modified: src/core/dns_cache.c --- Diff: https://github.com/kamailio/kamailio/commit/74847c386f627ba89a0cb282e85d653… Patch: https://github.com/kamailio/kamailio/commit/74847c386f627ba89a0cb282e85d653… --- diff --git a/src/core/dns_cache.c b/src/core/dns_cache.c index 554c7c9903..d9fc6a21cc 100644 --- a/src/core/dns_cache.c +++ b/src/core/dns_cache.c @@ -510,6 +510,13 @@ inline static struct dns_hash_entry* _dns_hash_find(str* name, int type, ret=0; now=get_ticks_raw(); *err=0; + + /* just in case that e.g. the VIA parser get confused */ + if(unlikely(!name->s || name->len <= 0)) { + LM_ERR("invalid name, no cache lookup possible\n"); + *err=-1; + return 0; + } again: *h=dns_hash_no(name->s, name->len, type); LM_DBG("(%.*s(%d), %d), h=%d\n", name->len, name->s, name->len, type, *h);