[sr-dev] [kamailio/kamailio] ims_registrar_scscf: drop subscription on notification failure (PR #3895)

<!-- Kamailio Pull Request Template --> <!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception --> #### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description <!-- Describe your changes in detail --> https://datatracker.ietf.org/doc/html/rfc3265#section-3.2.2 says that if a NOTIFY fails, the subscription should be removed. There is one exception only, when a Retry-After is specified. This is done in order to cleanup state and not keep it around for huge periods of time. This is preferred and the client is the one that should re-subscribe at intervals to fix the situation. Anyway, I guess I was super annoyed by the huge number of useless notifications that I'm getting for gone IMS clients. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3895 -- Commit Summary -- * ims_registrar_scscf: drop subscription on notification failure -- File Changes -- M src/modules/ims_registrar_scscf/registrar_notify.c (153) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3895.patch https://github.com/kamailio/kamailio/pull/3895.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3895 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3895(a)github.com>