[sr-dev] git:master:92ba30d6: janssonrpc-c: allow null json error property in rpc response

Module: kamailio Branch: master Commit: 92ba30d66e9e6bb686410f362f2b6e8d669ed295 URL: https://github.com/kamailio/kamailio/commit/92ba30d66e9e6bb686410f362f2b6e8… Author: Jason Newman <jason(a)getweave.com> Committer: Jason Newman <jason(a)getweave.com> Date: 2015-08-11T14:30:31-06:00 janssonrpc-c: allow null json error property in rpc response If the JSON RPC response contains an error property, check to see if it is a json_null or not before flagging the response as an error. --- Modified: modules/janssonrpc-c/janssonrpc_io.c --- Diff: https://github.com/kamailio/kamailio/commit/92ba30d66e9e6bb686410f362f2b6e8… Patch: https://github.com/kamailio/kamailio/commit/92ba30d66e9e6bb686410f362f2b6e8… --- diff --git a/modules/janssonrpc-c/janssonrpc_io.c b/modules/janssonrpc-c/janssonrpc_io.c index ffcc247..1e1a82b 100644 --- a/modules/janssonrpc-c/janssonrpc_io.c +++ b/modules/janssonrpc-c/janssonrpc_io.c @@ -587,9 +587,12 @@ int handle_response(json_t* response) return_obj = json_object(); json_t* error = json_object_get(response, "error"); + // if the error value is null, we don't care + bool _error = error && (json_typeof(error) != JSON_NULL); + json_t* result = json_object_get(response, "result"); - if(error) { + if(_error) { json_object_set(return_obj, "error", error); } @@ -597,7 +600,7 @@ int handle_response(json_t* response) json_object_set(return_obj, "result", result); } - if ((!result && !error) || (result && error)) { + if ((!result && !_error) || (result && _error)) { WARN("bad response\n"); internal = internal_error(JRPC_ERR_BAD_RESP, req->payload); json_object_update(return_obj, internal); @@ -621,7 +624,7 @@ int handle_response(json_t* response) goto free_and_end; } - if(error) { + if(_error) { // get code from error json_t* _code = json_object_get(error, "code"); if(_code) {