1 May
2019
1 May
'19
4:51 a.m.
Hello Juha,
I think the commit history might be a bit misleading here. The siptrace
module was reviewed on the github tracker, and the commits that you
quoted below were the result from this review.
This commits were developed in a private branch, and then completely merged.
You find the review history from me and the responses from the developer
(and others) here: https://github.com/kamailio/kamailio/pull/1912
About the actual issue - I had a look to this as well. It seems that the
logic for the duplicate_uri string might need to be changed.
I will have another look and fix it or will refer it to the original
developer.
Cheers,
Henning
Am 01.05.19 um 10:16 schrieb Juha Heinanen:
I haven't got any response about the misery with
siptrace module. I
checked its commit history and become to the conclusion that many
commits to master were done without any review whatsoever.
For example, there was this commit:
siptrace: remove unused trace flag
ionutionita92 authored and henningw committed on Mar 19
which obviously badly broke normal use of the module.
Then 10 days later the commit was reverted:
siptrace: add trace_flag after it was removed
ionutionita92 authored and henningw committed 29 days ago
This is not how Kamailio should be developed.
I'm proposing to revert the module back to 5.2 level after which new
commits can be made to it provided that each commit is carefully tested
before deployed.
-- Juha
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev(a)lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://skalatan.de/services