[sr-dev] git:master:9e48df92: modules/tm: no reason to reset KR on continuation of async requests

Module: kamailio Branch: master Commit: 9e48df9226b63aa8ba5232f6e02e8ba6038f1fe0 URL: https://github.com/kamailio/kamailio/commit/9e48df9226b63aa8ba5232f6e02e8ba… Author: Jason Penton <jason.penton(a)gmail.com> Committer: Jason Penton <jason.penton(a)gmail.com> Date: 2015-01-30T16:41:25+02:00 modules/tm: no reason to reset KR on continuation of async requests - maybe before continuing, a reply has been sent, request forwarded, etc... --- Modified: modules/tm/t_suspend.c --- Diff: https://github.com/kamailio/kamailio/commit/9e48df9226b63aa8ba5232f6e02e8ba… Patch: https://github.com/kamailio/kamailio/commit/9e48df9226b63aa8ba5232f6e02e8ba… --- diff --git a/modules/tm/t_suspend.c b/modules/tm/t_suspend.c index f07307d..4b12dcf 100644 --- a/modules/tm/t_suspend.c +++ b/modules/tm/t_suspend.c @@ -221,7 +221,12 @@ int t_continue(unsigned int hash_index, unsigned int label, Not a huge problem, fr timer will fire, but CANCEL will not be sent. last_received will be set to 408. */ - reset_kr(); + /* We should not reset kr here to 0 as it's quite possible before continuing the dev. has correctly set the + * kr by, for example, sending a transactional reply in code - resetting here will cause a dirty log message + * "WARNING: script writer didn't release transaction" to appear in log files. TODO: maybe we need to add + * a special kr for async? + * reset_kr(); + */ /* fake the request and the environment, like in failure_route */ if (!fake_req(&faked_req, t->uas.request, 0 /* extra flags */, uac)) {