8 Nov
2011
8 Nov
'11
9:44 a.m.
Hi,
First of all, so sorry for the late answer, and thank you for your patience!
in this patch I see you change also the file:
modules_k/presence/event_list.c
Why is the condition on the new event type needed there? Isn't
required for this event type to look at parameters as well?
The event parameters
are not static and predefined.
The subscribe message event header is compared to the definition of the
modul event definition during the event match in event_list.c
For example if the event header is the following:
Event:
ua-profile;profile-type=user;vendor="premier.example.com";model="trs8000";version="5.5"
So every user agent what is sending subscribe sending the vendor and
model and version etc parameters what AFAIK couldn't defined/compared in
modul add_event definition(modules_k/presence_profile/add_events.c),
because it's values are not predefined in RFC, and some vendors adding
additional vendor specific proprietary header fields too.
This is the reason why i modified modules_k/presence/event_list.c to not
check event parameters and event values, only compare the event name to
find a match.
Please let me know your thoughts!
Cheers,
Misi
The new module should be fine otherwise.
Cheers,
Daniel
On 10/20/11 6:10 PM, Mihaly Meszaros wrote:
Module: sip-router
Branch: misi/ua-profile
Commit: d3a2b22db7e8c7c77f8bdf8af25ff23fe1316076
URL:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d3a2b22…
Author: Mihály Mészáros<misi(a)niif.hu>
Committer: Mihály Mészáros<misi(a)niif.hu>
Date: Thu Oct 20 17:49:51 2011 +0200
modules_k/presence_profile: new modul for basic ua-profile event support
- This is a new modul that is using sip event framework for
endpoint config provisioining.
Currently it has very basic functionality.
---
Makefile | 4 +-
modules_k/presence/event_list.c | 2 +-
modules_k/presence_profile/Makefile | 11 ++
modules_k/presence_profile/README | 77
+++++++++++++
modules_k/presence_profile/add_events.c | 66 +++++++++++
modules_k/presence_profile/add_events.h | 40 +++++++
modules_k/presence_profile/doc/Makefile | 4 +
.../presence_profile/doc/presence_profile.xml | 39 +++++++
.../doc/presence_profile_admin.xml | 72 ++++++++++++
modules_k/presence_profile/presence_profile.c | 118
++++++++++++++++++++
modules_k/presence_profile/presence_profile.h | 38 +++++++
11 files changed, 468 insertions(+), 3 deletions(-)
Diff:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=d3a…
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev