Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: more algorithms, SA improvements (#2731)

@henningw commented on this pull request.

Thanks for the pull request, i have added one comment regarding the time handling. Are there module any documentation updates necessary as well?

@@ -100,8 +100,15 @@ static void string_to_key(char* dst, const str key_string)

} }

+static uint choose_nlmsg_seq (void)

Any particular reason why you choose to implement this function instead of the previous time(0) call? The clock_gettime() function is not available at Mac OS, and probably need a wrapper around it as e.g. in the cdp module. If not necessary, we should probably stay with the previous way.