9 Mar
2020
9 Mar
'20
4:22 p.m.
A few things to add from my side:
- many files are generated from an ASN.1 definition file (e.g. from
HI1NotificationOperations.asn), but the asn1 files are missing. It would be great if they
could be added, otherwise future extensions are difficult.
- there is a CMake file included (CMakeLists.txt), is is still used? We use make as our
build system in Kamailio. Otherwise it should be removed.
- there are a lot of include files from the asnc1 added (like OBJECT_IDENTIFIER.c/h,
BIT_STRING.c/h etc..). These files are all provides as part of the asnc1 package and
should not be included as part of the module.
- the module also introduce a new function in the core "int received_in_via( struct
sip_msg *msg )" @miconda maybe you can have a look to this
I just did a quick test to use the asn1c system files - the module still compiles with
them (after fixing one bug related to a crypto refactoring). So it looks quite good and
the module size was reduced from ~19.000 lines to 5600 lines. :-) The only change
necessary in the Makefile was to add one include:
```
DEFS+=-DKAMAILIO_MOD_INTERFACE \
-I/usr/share/asn1c/
```
There are a couple of warnings related to the use of BSD_SOURCE, but they could be fixed
also later.
After you added the documentation it can be merged, with the asn1c files removed of
course. It probably makes sense to merge it manually, to prevent the whole files to be
introduced into the repository and then deleted again. I can do it, no problem.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2209#issuecomment-596760258