Re: [sr-dev] git:master: rr: dont set msg flag FL_RR_ADDED for record_route() in branch_route

On 31/10/14 08:57, Juha Heinanen wrote:

Daniel-Constantin Mierla writes:

...

rr: dont set msg flag FL_RR_ADDED for record_route() in branch_route

• the operation is specific only for the branch

is this specific only to master?

It will be backported to 4.2.

I was thinking that 4.1 has the same kind of issue (i.e., record_route() cannot be used in more than one branch_route[]) -- unlike 4.2 and master that uses a msg flag to mark the request when record routing is done, 4.1 and older versions use a local copy of msg->id, but that is same for each branch. Not sure if worth looking at a fix for it, given that nobody seemed to run record_route() in branch_route with older versions.

Cheers, Daniel