[sr-dev] Re: [kamailio/kamailio] Topos: Added Call-ID mask (PR #3334)

@toharish commented on this pull request. } } dialog = (get_to(&msg)->tag_value.len>0)?1:0; - if(dialog) { - /* dialog request */ - tps_request_received(&msg, dialog); - } + + tps_request_received(&msg, dialog); + To mask the Call-ID after the processing will be a challenge as TOPOS is using Call-ID as the key and further it is identifying from the request/response as UPSTREAM / DOWNSTREAM after tps_storage_load_dialog function call. which means when there is a message from Downstream we will not be able to UnMask first before loading the dialog from the database as we are not knowing the direction. To solve this we will have to add additional cookies and headers similar to Topoh which will be too much additional processing instead this approach of masking when receiving from Upstream and hiding other headers before sending downstream and Unmasking before sending to Upstream and hiding other headers when received from downstream will be better. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3334#discussion_r1085307340 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3334/review/1267482704(a)github.com>