Re: [sr-dev] [kamailio/kamailio] userblacklist: added missing kemi functions (#2190)

miconda commented on this pull request. + return -1; + } + /* try to add the table */ + if (add_source(table) != 0) { + LM_ERR("could not add table"); + return -1; + } + + gnode = table2dt(table); + if (!gnode) { + LM_ERR("invalid table '%s'\n", table); + return -1; + } + + arg = pkg_malloc(sizeof(struct check_blacklist_fs_t)); The `arg` is allocated in pkg, shouldn't it be freed after the call of `check_blackist()`? There are similar cases in the other functions. I am not familiar with the code of the module, but upon quick check there are at least some error cases inside `check_blackist()` that just return back without any pkg free. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2190#pullrequestreview-338775644