Re: [sr-dev] [kamailio] permissions: possibility to specify time period in routing rules, fun… (#382)

Thank you for your contribution, however, there are couple of remarks I want to do: * patch is rather hard to follow because along with new code you reformatted the old code, resulting in bigger patch * reformatting the code to be more standard and remove trailing withe spaces is appreciated, but has to be done as a stand alone patch * log_attempt() seems quite redundant to other existing alternatives: xlog() with a particular facility directed to own file or file_write() from corex module in master branch My suggestions: * remove addition of log_attempt() (it can still be discussed if you think so, but in that case make a separate pull request for it) * make a patch only for the new functionality with timerec * make a patch for reformatting the code/removing training white spaces * the last two patches can be in the same pull request --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/382#issuecomment-151777052