Daniel-Constantin Mierla writes:
If there is a strong desire to keep add_contact_alias(), it should be kept after all, but properly documented that has the limitations on making new contact visible and should not be used in a sip server instance used for presence, dialog, ...
i have made enhancements to a large number of functions and never created new ones unless there has been backwards incompatible change in parameters or performance penalty.
if there has not been either in case of set_contact_alias, it should not have not created in the first place and therefore i'm against deprecating add_contact_alias.
Or, even better in my opinion at this time, just point both to same C function. Overall, as this is discussion about deprecating something, it will happen more recently with the future next major release, 4.3.
i didn't get answer to performance issue. is there penalty when changes are applied to the message by set_contact_alias function? if yes, then add_contact_alias code should not be changed.
-- juha