Hi Matthew,
first, thanks for your new modules added to GIT repository.
I added usage of pkg-tool to locate the needed libs -- updated the Makefiles of the modules. While doing that I noticed that jsonrpc-c module depends on libevent. On Mac OS X that seemed to be just libevent package, but I saw some other variants on ports (like libev). You should add a note on README about this dependency as it is not a standard lib.
Second, I discovered that it uses Linux specific extensions, specifically timerfd: http://www.kernel.org/doc/man-pages/online/pages/man2/timerfd_create.2.html
Add a note about this as well, the module does not compile on Mac OS X for example, perhaps does not compile on *BSDs as well.
Cheers, Daniel
On 8/22/11 11:12 PM, Matthew Williams wrote:
Module: sip-router Branch: master Commit: 044a6b9187791bcc23895f8e3fcef0b695bd2838 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=044a6b91...
Author: Matthew Williamsmatthew@flowroute.com Committer: Matthew Williamsmatthew@flowroute.com Date: Mon Aug 22 16:09:01 2011 -0500
Added jsonrpc-c module, providing a client interface to json-rpc services over netstrings.
modules/jsonrpc-c/.gitignore | 10 + modules/jsonrpc-c/Makefile | 19 + modules/jsonrpc-c/README | 166 +++++++++ modules/jsonrpc-c/TODO | 1 + modules/jsonrpc-c/doc/Makefile | 4 + modules/jsonrpc-c/doc/jsonrpc.xml | 37 ++ modules/jsonrpc-c/doc/jsonrpc_admin.xml | 154 +++++++++ modules/jsonrpc-c/jsonrpc.c | 174 ++++++++++ modules/jsonrpc-c/jsonrpc.h | 52 +++ modules/jsonrpc-c/jsonrpc_io.c | 557 +++++++++++++++++++++++++++++++ modules/jsonrpc-c/jsonrpc_io.h | 52 +++ modules/jsonrpc-c/jsonrpc_mod.c | 172 ++++++++++ modules/jsonrpc-c/jsonrpc_request.c | 165 +++++++++ modules/jsonrpc-c/jsonrpc_request.h | 33 ++ modules/jsonrpc-c/netstring.c | 198 +++++++++++ modules/jsonrpc-c/netstring.h | 48 +++ 16 files changed, 1842 insertions(+), 0 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=044a...
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev