Re: [sr-dev] [kamailio/kamailio] extend siptrace module tracing methods (#1912)

henningw commented on this pull request.

@@ -304,10 +338,30 @@ static int mod_init(void)

/* register callbacks to TM */ if(load_tm_api(&tmb) != 0) { LM_WARN("can't load tm api. Will not install tm callbacks.\n"); - } else if(tmb.register_tmcb(0, 0, TMCB_REQUEST_IN, trace_onreq_in, 0, 0) - <= 0) { - LM_ERR("can't register trace_onreq_in\n"); - return -1; + } + + if (load_dlg_api(&dlgb) < 0) { + LM_WARN("can't load dlg api. Will not install dialog callbacks.\n");

It was only a minor comment. But having though about one more time its makes sense now with your comment.