Re: [sr-dev] [kamailio/kamailio] siptrace: use xavps to pass data for the duration of transaction/dialog (#1963)

henningw commented on this pull request. Thank you, great that you could get rid of the serialization/de-serialization code. I had only two small remarks to the pull request. I think it can be merged, you can work on that also directly in the repository. /* could use the dest_info we've already parsed but there's no way to pass * it to DLGCB_CREATED callback so the only thing to do is keep * it as uri, serialize in a dlg_var and parse again in DLGCB_CREATED */ if(corid) { - info->correlation_id = *corid; + info->correlation_id.s = (char *)(info + 1); Maybe I misunderstood the code here, but why you use +1? If you want to increment the pointer for siptrace_info_t length, maybe use sizeof? static str time_us_column = str_init("time_us"); /* 10 */ static str totag_column = str_init("totag"); /* 11 */ -static str siptrace_info_dlgkey = str_init("__siptrace_info_dlg_key__"); -static str siptrace_info_avp_str = str_init("$avp(__siptrace_info_avp__)"); +#define XAVP_TRACE_INFO_NAME "trace_info" Would be good to document this as well in the README, to prevent accidential overlapping with existing xavps. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1963#pullrequestreview-241442745