[sr-dev] Re: [kamailio/kamailio] nathelper: fixed handle_ruri_alias() for alias being an IPv6 (PR #3913)

Over all, it should be ok to merge, just with the note that it is preferred to declare the variable at the beginning of the block. A few in this PR are in the middle. It is ok to have them at the beginning of the functions or at the beginning of the blocks, e.g.,: ``` if(cond) { int v; ... v = ... } ``` Also, I think that rather recent someone reported that declaring the iterator variable in the `for` (i.e., `for(int i = 0; ...) { ... }`) was giving some error on some old but still used OS. So maybe it should still be avoided for a while. I think there are places in the code where the above suggestions were not followed, but thought it worth listing them here. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3913#issuecomment-2228692870 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3913/c2228692870(a)github.com>