2 okt 2013 kl. 16:01 skrev Daniel-Constantin Mierla <miconda(a)gmail.com>om>:
On 10/2/13 3:54 PM, Olle E. Johansson wrote:
A few comments:
I think the module name should be "queue". The moh-part is a just a nice way of
handling the queue...
I don't like "queue" alone, because it is not
suggestive for the functionality. It can be callqueue or something else that contains
queue if the current name is no longer preferred, but not just 'queue'.
I
see. +1 for "callqueue".
/O
Cheers,
Daniel
From reading the docs:
- The example on 3.4. moh_maxcalls illustrates usage of mohdir.
- Change "from the main (request) route" to "a request route". Routes
can call routes.
I would love for this module to expose the queue in an xavp (as an alternative to the
database) so I can manipulate weights and stuff. Queues need management. I would also like
to be able to pick a call out of the queue at any point, regardless of position. But
that's a future change. This is a very good contribution.
I don't think naming audio files after payload number is a good scheme. Payload
numbers are dynamic for all new codecs and one should use the name tags. I think we should
simply copy the file name extensions used by Asterisk for the codecs, like
"alaw" for alaw. Or the names used in rtpmap. One of them - but not the numbers,
that is not extensible enough as they are no longer assigned. Opus will not get a fixed
number, just a name tag.
/O
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
--
Daniel-Constantin Mierla -
http://www.asipto.com
http://twitter.com/#!/miconda -
http://www.linkedin.com/in/miconda
Kamailio Advanced Trainings - Berlin, Nov 25-28; Miami, Nov 18-20, 2013
- more details about Kamailio trainings at
http://www.asipto.com -
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev