Re: [sr-dev] [kamailio/kamailio] topos: adding param contact_hostname (#1596)

I am fine to add this parameter, but the patch lacks checking if the size is exceeding the available space in the buffer -- it checks only sv.len, which is the uri from where to extract ip, port and transport, not it should also check for param len. If this and the docs are added, then can be merged. There is an alternative to use record_route_preset(), because the contact address is built from the Record-Route URI added by kamailio. But again, I am fine to add a parameter if it is found to be more convenient and simpler for config. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1596#issuecomment-405879711