3 Jun
2022
3 Jun
'22
12:36 p.m.
Thanks for the PR!
For reference, the git commit message has to be prefixed with the component name, in this
case `tm: `, not the pull request name.
Then, I don't think the list of reply codes and classes has to be in shared memory,
they do not change at runtime. I see same is done in dispatcher module, so probably should
be changed in both modules later.
I am going to merge it manually.
Thanks for feedback Daniel.
i will pay more attention to git commit message next time.
for list of reply codes in shared memory i wanted also to be able to update it dynamically
through kamcmd.
even if right now i dont see (talking for myself) it happen quite often.
so i started by put them in shared memory to continue after.
Thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3129#issuecomment-1145784239
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3129/c1145784239(a)github.com>