Thought about to add this functionality to the module. If this approach seems to be more correct, then I can move my code in a module, but, in my opinion, it is not very correct. ________________________________ Andrey Rybkin JID: rybkin.a@bks.tv E-Mail: rybkin.a@bks.tv
2014-10-28 16:46 GMT+03:00 Alex Hermann alex@speakup.nl:
On Tuesday 28 October 2014, Андрей Рыбкин wrote:
Module DMQ_SYNC: The module add replication between multiple servers via DMQ module. Currently only usrloc replications.
I think some decision should be made on where syncing code should be placed. The htable module has dmq sync integrated, now you introduce a module dedicated to syncing via dmq.
I have no strong preference, but am against different implementations depending on the module. So i would prefer either dmq-sync integrated into each module, or one dmq_sync module. Not a combination of both.
TODO:
- dialog replications.
- bugfixes.
Patch fo DMQ:
- add find_dmq_node_uri function to API dmq_node_t* find_dmq_node_uri(str* uri)
- add init_callback to dmq_peer int init_callback()
Except for the broken indenting, this seems equal to my code. If it is mine, and the code is useful, please cherry-pick the relevant commits so authorship is retained.
-- Greetings,
Alex Hermann