Re: [sr-dev] Dialog module issue on OS/X

On 30 Jul 2014, at 15:20, Daniel-Constantin Mierla <miconda(a)gmail.com> wrote: I did not dare to commit it, since I have no idea of the effects. I could not compile without this change.

/O > Cheers, > Daniel > > On 04/06/14 18:50, Olle E. Johansson wrote: >> I could not load the dialog module, because of a linking problem with the symbol destroy_dlg. >> >> Found that it's declared "inline" twice which may cause an issue. With this change, that I don't dare to commit myself, I could load dialog and explore it. Can someone take a look at this, someone that understands dialog and stuff? >> >> This was on OS/X. >> >> Thanks >> /O >> >> diff --git a/modules/dialog/dlg_hash.h b/modules/dialog/dlg_hash.h >> index 6994256..174ef15 100644 >> --- a/modules/dialog/dlg_hash.h >> +++ b/modules/dialog/dlg_hash.h >> @@ -214,7 +214,7 @@ static inline void unlink_unsafe_dlg(dlg_entry_t *d_entry, dlg_cell_t *dlg) >> * \brief Destroy a dialog, run callbacks and free memory >> * \param dlg destroyed dialog >> */ >> -inline void destroy_dlg(dlg_cell_t *dlg); >> +void destroy_dlg(dlg_cell_t *dlg); >> /*! >> >> >> _______________________________________________ >> sr-dev mailing list >> sr-dev(a)lists.sip-router.org >> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev > -- > Daniel-Constantin Mierla - http://www.asipto.com > http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda >