[sr-dev] Re: [kamailio/kamailio] http_client: Add parameter connect_timeout_ms / timeout_ms (2) (PR #3611)

@miconda commented on this pull request. </para> <para> <emphasis> - Default value is zero, i.e., - the timeout function is disabled. + Default value is 4. I am for adding `timeout_mode`, seems cleaner to understand, imo. The only thing on your proposal that breaks the existing functionality is the ability to disable the timeout. I agree that there should be a timeout by default and I cannot think of a use case for disabling it (maybe when it is sure the http service is available(?!?) and not setting it saves some cpu/timer cycles), so I would propose the following: - if timeout_mode is 0, then no timeout is set (disabled) - if timeout_mode is 1, then timeout value is in seconds and if connection_timeout is not set, then it is set to 4 (default), setting CURLOPT_TIMEOUT - if timeout_mode is 2, then timeout value is in milliseconds and if connection_timeout is not set, then it is set to 4000, setting CURLOPT_TIMEOUT_MS -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3611#discussion_r1370110775 You are receiving this because you are subscribed to this thread. Message ID: &lt;kamailio/kamailio/pull/3611/review/1694764625(a)github.com&gt;