9 Dec
2019
9 Dec
'19
11:57 a.m.
Overall I am fine with the PR, but because of limited time to test, I am not sure if there
is same result now that the lookup of `list` and `xavp` is no longer done only once in
`build_contact()`. In previous version the attributes for all contacts were done inside
`build_contact()` using this single lookup. Now the lookup is done for each contact inside
the helper function.
I expect is the same, based on quick thinking. If you did the tests and the result is the
same in terms of what is stored in xavp and the order of values, then I am fine to merge.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2168#issuecomment-563204545