[sr-dev] git:4.3:48996cc1: modules/htable: improves error message when loading from database

Module: kamailio Branch: 4.3 Commit: 48996cc1e879a2abf96306fc69ace2a86b8ef836 URL: https://github.com/kamailio/kamailio/commit/48996cc1e879a2abf96306fc69ace2a… Author: Mikko Lehto &lt;mslehto(a)iki.fi&gt; Committer: Daniel-Constantin Mierla &lt;miconda(a)gmail.com&gt; Date: 2015-07-17T12:24:41+02:00 modules/htable: improves error message when loading from database (cherry picked from commit f39736b276878f0de1e0471311119f12f1878801) --- Modified: modules/htable/ht_db.c --- Diff: https://github.com/kamailio/kamailio/commit/48996cc1e879a2abf96306fc69ace2a… Patch: https://github.com/kamailio/kamailio/commit/48996cc1e879a2abf96306fc69ace2a… --- diff --git a/modules/htable/ht_db.c b/modules/htable/ht_db.c index 06f3057..4288554 100644 --- a/modules/htable/ht_db.c +++ b/modules/htable/ht_db.c @@ -197,11 +197,17 @@ int ht_db_load_table(ht_t *ht, str *dbtable, int mode) do { for(i=0; i<RES_ROW_N(db_res); i++) { - if(RES_ROWS(db_res)[i].values[0].type!=DB1_STRING - || VAL_NULL(&RES_ROWS(db_res)[i].values[0])) { - LM_ERR("key type must be string and its value not null\n"); + if(VAL_NULL(&RES_ROWS(db_res)[i].values[0])) { + LM_ERR("key value must not be null\n"); goto error; } + + if(RES_ROWS(db_res)[i].values[0].type!=DB1_STRING) { + LM_ERR("key type must be string (type=%d)\n", + RES_ROWS(db_res)[i].values[0].type); + goto error; + } + kname.s = (char*)(RES_ROWS(db_res)[i].values[0].val.string_val); if(kname.s==NULL) { LM_ERR("null key in row %d\n", i);