[SR-Dev] git:andrei/fixups: avp: minor fixes & comments

Module: sip-router Branch: andrei/fixups Commit: 36fe005907cf7e27b0014f0a50d9ae3095174bbb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=36fe005… Author: Andrei Pelinescu-Onciul &lt;andrei(a)iptel.org&gt; Committer: Andrei Pelinescu-Onciul &lt;andrei(a)iptel.org&gt; Date: Thu Nov 27 01:20:52 2008 +0100 avp: minor fixes & comments - free_avp_name() for a regexp avp did not use regfree(...) - changed free_avp_name() prototype to use avp_flags_t for the type - added comments for parse_avp_ident() --- usr_avp.c | 41 +++++++++++++++++++++++++++++++++++++++-- usr_avp.h | 2 +- 2 files changed, 40 insertions(+), 3 deletions(-) diff --git a/usr_avp.c b/usr_avp.c index e70479c..eea9894 100644 --- a/usr_avp.c +++ b/usr_avp.c @@ -838,6 +838,39 @@ int parse_avp_name( str *name, int *type, int_str *avp_name, int *index) return ret; } + +/** parse an avp indentifier. + * + * Parses the following avp indentifier forms: + * - "i:<number>" - old form, deprecated (e.g. i:42) + * - "s:<string>" - old form, deprecated (e.g. s:foo) + * - "<track>.<name>" (e.g.: f.bar) + * - "<track>.<name>[<index>]" (e.g.: f.bar[1]) + * - "<track><class>.<name>" (e.g: tu.bar) + * - "<track><class>.<name>[<index>]" (e.g: fd.bar[2]) + * - "<string>" (e.g.: foo) + * Where: + * <string> = ascii string + * <id> = ascii string w/o '[', ']', '.' and '/' + * <name> = <id> | '/' regex '/' + * (Note: regex use is deprecated) + * <track> = 'f' | 't' | 'g' + * (from, to or global) + * <class> = 'r' | 'u' | 'd' + * (uri, user or domain) + * <index> = <number> | '-' <number> | '' + * (the avp index, if missing it means AVP_INDEX_ALL, but + * it's use is deprecated) + * More examples: + * "fr.bar[1]" - from track, uri class, avp "bar", the value 1. + * "tu./^foo/" - to track, user class, all avps for which the name + * starts with foo (note RE in avp names are deprecated). + * "t.did" - to track, "did" avp + * + * @param name - avp identifier + * @param *attr - the result will be stored here + * @return 0 on success, -1 on error + */ int parse_avp_ident( str *name, avp_ident_t* attr) { unsigned int id; @@ -967,6 +1000,7 @@ int parse_avp_ident( str *name, avp_ident_t* attr) name->s[name->len-1]=0; if (regcomp(attr->name.re, name->s+1, REG_EXTENDED|REG_NOSUB|REG_ICASE)) { pkg_free(attr->name.re); + attr->name.re=0; name->s[name->len-1] = '/'; goto error; } @@ -1010,10 +1044,13 @@ int parse_avp_spec( str *name, int *type, int_str *avp_name, int *index) } } -void free_avp_name( int *type, int_str *avp_name) +void free_avp_name(avp_flags_t *type, int_str *avp_name) { - if ((*type & AVP_NAME_RE) && (avp_name->re)) + if ((*type & AVP_NAME_RE) && (avp_name->re)){ + regfree(avp_name->re); pkg_free(avp_name->re); + avp_name->re=0; + } } int add_avp_galias_str(char *alias_definition) diff --git a/usr_avp.h b/usr_avp.h index 2b68107..49741cc 100644 --- a/usr_avp.h +++ b/usr_avp.h @@ -197,7 +197,7 @@ int add_avp_galias(str *alias, int type, int_str avp_name); int parse_avp_ident( str *name, avp_ident_t* attr); int parse_avp_name( str *name, int *type, int_str *avp_name, int *index); int parse_avp_spec( str *name, int *type, int_str *avp_name, int *index); -void free_avp_name( int *type, int_str *avp_name); +void free_avp_name( avp_flags_t *type, int_str *avp_name); /* AVP flags functions */ #define MAX_AVPFLAG ((unsigned int)( sizeof(avp_flags_t) * CHAR_BIT - 1 - AVP_CUSTOM_FLAGS))