[sr-dev] git:4.3:9c2dbc86: modules/[rls|presence_xml]: fixes warning [-Wtautological-compare]

Module: kamailio Branch: 4.3 Commit: 9c2dbc86a63c6bc403798d8ba48dfea764ca2537 URL: https://github.com/kamailio/kamailio/commit/9c2dbc86a63c6bc403798d8ba48dfea… Author: Mikko Lehto &lt;mslehto(a)iki.fi&gt; Committer: Daniel-Constantin Mierla &lt;miconda(a)gmail.com&gt; Date: 2015-07-17T12:23:47+02:00 modules/[rls|presence_xml]: fixes warning [-Wtautological-compare] warning: comparison of unsigned expression < 0 is always false (cherry picked from commit d5339cf397b83b79cd1594e37df69990374ec467) --- Modified: modules/presence_xml/presence_xml.c Modified: modules/rls/rls.c --- Diff: https://github.com/kamailio/kamailio/commit/9c2dbc86a63c6bc403798d8ba48dfea… Patch: https://github.com/kamailio/kamailio/commit/9c2dbc86a63c6bc403798d8ba48dfea… --- diff --git a/modules/presence_xml/presence_xml.c b/modules/presence_xml/presence_xml.c index 29bf3ec..f8781ef 100644 --- a/modules/presence_xml/presence_xml.c +++ b/modules/presence_xml/presence_xml.c @@ -382,7 +382,7 @@ static int pxml_add_xcap_server( modparam_t type, void* val) LM_ERR("while converting string to int\n"); goto error; } - if(port< 0 || port> 65535) + if(port< 1 || port> 65535) { LM_ERR("wrong port number\n"); goto error; diff --git a/modules/rls/rls.c b/modules/rls/rls.c index 23c6a7c..26d9be0 100644 --- a/modules/rls/rls.c +++ b/modules/rls/rls.c @@ -333,7 +333,7 @@ static int mod_init(void) port_str.len, port_str.s); return -1; } - if(xcap_port< 0 || xcap_port> 65535) + if(xcap_port< 1 || xcap_port> 65535) { LM_ERR("wrong xcap server port\n"); return -1;