#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
I've tested cmake-build in the FreeBSD environment, as requested by @miconda in
#4099.
And founded some troubles.
First of all are: specific flags for FreeBSD and arch-name for FreeBSD cmake-environment.
I've fixed it in the PR.
But there're some unresolved problems I want to discuss...
A `LOCK_METHOD` problem:
There's a `LOCK_METHOD` variable in defs.cmake:
https://github.com/kamailio/kamailio/blob/6b0b8cb84b7d0e965d50bdf0dfa542300…
And the explicit usage `LOCK_METHOD` as `USE_FUTEX` in a compile_definitions:
https://github.com/kamailio/kamailio/blob/6b0b8cb84b7d0e965d50bdf0dfa542300…
I suppose it's incorrect while some OSs (FreeBSD, ex.) doesn't tested with
futexlock.h earlier.
A resolv-link problem:
There're an explicit links of the resolv library:
https://github.com/kamailio/kamailio/blob/6b0b8cb84b7d0e965d50bdf0dfa542300…
https://github.com/kamailio/kamailio/blob/6b0b8cb84b7d0e965d50bdf0dfa542300…
I think it's incorrect while some OSs (FreeBSD, ex.) uses builtin resolv (libc,
etc).
Initially сmake is built successful after the above fixes.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4104
-- Commit Summary --
* cmake: add amd64 arch fallback
* cmake: add FreeBSD support
-- File Changes --
M cmake/compiler-specific.cmake (2)
M cmake/defs.cmake (4)
M cmake/os-specific.cmake (3)
A cmake/os-specific/freebsd.cmake (37)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4104.patch
https://github.com/kamailio/kamailio/pull/4104.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4104
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4104(a)github.com>