[sr-dev] Re: [kamailio/kamailio] lib/srdb1/schema: ims_dialog definitions (PR #4101)

@henningw commented on this pull request. Thanks for the PR. I did a quick review for the differences. The general standardisation regarding the column sizes is great, the re-ordering of some colums is also fine of course. I have added two remarks that in my opinion should be addressed. + <size>&uri_len;</size> + <description>The URI of the FROM header (as per INVITE)</description> + </column> + + <column> + <name>from_tag</name> + <type>string</type> + <size>&from_tag_len;</size> + <description>The tag parameter serves as a general mechanism to + identify a dialog, which is the combination of the Call-ID along + with two tags, one from participant in the dialog.</description> + </column> + + <column> + <name>caller_cseq</name> This column was called "caller_original_cseq" previously, and its also like this in the code. We can change it, but then we also need to adapt the module code I think. + <name>caller_contact</name> + <type>string</type> + <size>&uri_len;</size> + <description>Caller's contact uri.</description> + </column> + + <column> + <name>caller_sock</name> + <type>string</type> + <size>&domain_len;</size> + <description>Local socket used to communicate with caller</description> + </column> + + <column> + <name>callee_sock</name> This is not needed for the dialog_in table, it was also not in the previous scheme. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4101#pullrequestreview-2552950525 You are receiving this because you are subscribed to this thread. Message ID: &lt;kamailio/kamailio/pull/4101/review/2552950525(a)github.com&gt;