[sr-dev] [kamailio/kamailio] auth: allow challenge from failure/onreply routes (#1641)

<!-- Kamailio Pull Request Template --> <!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception --> #### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description <!-- Describe your changes in detail --> when handling registration requests we create a transaction for async process and need to use t_on_failure / t_on_failure. when the async processes returns we want to call auth_challenge without the need to create `fake` routes ``` onreply_route[KZ_AUTHORIZATION_OK] { $var(password) = $(kzR{kz.json,Auth-Password}); $var(nonce) = $adn; if( $(kzR{kz.json,Event-Name}) == "authn_err" ) { ==>> auth_challenge("$fd", "0"); xlog("L_INFO", "$ci|end|issued auth challenge from async registrar for $Au $si:$sp\n"); exit; } else { xlog("L_INFO", "$ci|log|authenticated $Au via registrar async process\n"); route(SAVE_AUTHORIZATION); } } failure_route[KZ_AUTHORIZATION_ERROR] { xlog("L_INFO", "$ci|log|registrar process failed with $T_reply_code for $Au $si:$sp\n"); ==>> auth_challenge("$fd", "0"); exit; } ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1641 -- Commit Summary -- * auth: allow challenge from failure/onreply routes -- File Changes -- M src/modules/auth/auth_mod.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1641.patch https://github.com/kamailio/kamailio/pull/1641.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1641