Re: [sr-dev] [dialog MI dlg_end_dlg] error when terminating a dialog in state 2 (never removed from memory)

Hey Iñaki, Iñaki Baz Castillo wrote: I don't think that it leaks. Please have a look at the get_expired_dlgs(unsigned int time) function in dlg_timer.c: The loop condition to get all expired dialogs is while( tl!=end && tl->timeout <= time) { ^^^^^^^^^^^^^^^^^^^ [...] } The unit of "time" is ticks, so the while-loop picks those dialogs for cleanup whose timeout value is lower or equal the current number of ticks. Certainly, this is true for a timeout of zero. I think it makes sense this way because dlg_end_dlg isn't supposed to change the dialog state in case of failure (and checking mi_terminate_dlg(), I believe it doesn't), so a subsequent, UAC-initiated CANCEL shouldn't be any different from such a CANCEL not involving a call to dlg_end_dlg(). A leak in this case would have been detected already, hopefully. Nevertheless, I think the current dialog module should be hotfixed such that dlg_end_dlg doesn't end dialogs in the "early" state simply because it's not capable of doing so. The upcoming, refurbished dialog module should do better though. Cheers, --Timo