Patches item #2961414, was opened at 2010-03-01 20:20 Message generated for change (Settings changed) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x
Status: Closed Resolution: Accepted
Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody)
Assigned to: Daniel-Constantin Mierla (miconda)
Summary: fix for crash when Content-length too big - ID: 281827
Initial Comment: are there any valid use cases for a content-length being bigger than the rest of of the packet?
i have not tested the issue with kamailio 3.0.
----------------------------------------------------------------------
Comment By: Daniel-Constantin Mierla (miconda)
Date: 2010-03-17 21:05
Message: Patch applied.
----------------------------------------------------------------------
Comment By: Marcus Hunger (marcushunger) Date: 2010-03-02 11:51
Message: i retried this with vanilla-kamailio 1.5.4 downloaded from kamailio.org and it crashs.
----------------------------------------------------------------------
Comment By: Marcus Hunger (marcushunger) Date: 2010-03-01 21:11
Message: so there's already a fix? i tried this on 1.5.4, and it crashed. maybe i made a mistake merging it to my branch. i am going to check this tomorrow.
----------------------------------------------------------------------
Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-01 20:51
Message: This should not happen, as both pairs (msg_buf,msg_len) and (body,body_len) are set internally. The issue with the nathelper was because the len was taken from content-lenght header, which can be wrong. The discussion ended in whether to auto-correct the content-lenght value or return 400 bad message. In 1.5 the fix to avoid crash was to return error to script, 400 can be sent by using sanity module.
----------------------------------------------------------------------
Comment By: Marcus Hunger (marcushunger) Date: 2010-03-01 20:22
Message: sorry, i was not logged in while posting.
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414...