[sr-dev] Websocket module: Suggestions

Hi! Looking at Websockets from a SNMP perspective, I would like to thank you for implementing counters - I just added them to SNMPstats. In addition, I would like to be able to discover sub-protocols used (msrp, sip). I fail to see how I can do that now. Do we have a Core API for publishing read-only data from modules? I guess we maybe could use PVs or XAVPs for that. An ugly way would be to implement RPC in SNMPstats and issue RPC commands internally to fetch data, but that means a lot of serializing that really is not needed as SNMPstats generally fetches one parameter (OID) at a time, not complete sets. Also, some of the modparam parameters could be exposed as cfg params - which would make it easier to change them at runtime with sercmd, but also expose them in SNMPstats. I think keepalive_interval and keepalive_timeout are candidates for this. Cheers! /O ----------------------------- Copy of my commit message, just to repeat myself: Hint to developers: If you add statistics and selects in your module, you make it very easy to add SNMP support for your module. Then SNMPstats can just use generic APIs to find your data. Please also add a generic way of finding out if a module is configured and used too, if possible. Sometimes modules are just loaded, but not used anywhere. Better to reflect real data in SNMP if possible. Using the old "SER" way of using selects for config data that is allowed to change at runtime opens up for SNMP writes to manage your module as well. And of course, using selects and counters/statistics variables also helps the RPC interface, so it's both cool and the Right Thing To Do (TM). Yes, commit messages can be informative as well. :-)