Hello,
this commit doesn't look good and safe on long term.
A .h file must not include initializations of variables and full definitions of functions. It should be with structure/types definitions, function prototypes and 'extern' declarations. Then the .h file must be guarded with defines, to avoid including it many times.
The initializations of variables and implementations of functions must be in .c files.
Cheers, Daniel
On 12/01/15 11:25, Eloy Coto wrote:
Module: kamailio Branch: master Commit: 85fcd786e20ed1f06dad1746029a7056b0476a98 URL: https://github.com/kamailio/kamailio/commit/85fcd786e20ed1f06dad1746029a7056...
Author: Eloy Coto eloy.coto@gmail.com Committer: Eloy Coto eloy.coto@gmail.com Date: 2015-01-12T10:25:12Z
Warning cleanup.
Added: modules/statsd/lib_statsd.h Modified: modules/statsd/statsd.c Removed: modules/statsd/lib_statsd.c
Diff: https://github.com/kamailio/kamailio/commit/85fcd786e20ed1f06dad1746029a7056... Patch: https://github.com/kamailio/kamailio/commit/85fcd786e20ed1f06dad1746029a7056...
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev