Hi, it's an understandable point of view.
My need is to be able to start/restart kamailio even if redis is just temporarily unavailable, and manage the "connection refused" errors accordingly. I have a failover strategy for those cases, but want to keep processing calls. When redis then returns available, kamailio will connect correctly. It's really an edge case, but I feel safer.
Configurations that depend more strongly on redis being available should not use this optional configuration item, keeping the current behaviour.
Cheers, Giacomo
On 13 April 2015 at 16:49, Vicente Hernando vhernando@systemonenoc.com wrote:
Hello,
I do not like the idea behind the patch. If redis database is down, what is the point of launching kamailio anyway? If you need redis to run you should fix it, or not to use the ndb_redis module if you want to run without redis.
Any other opinions are welcome.
Cheers, Vicente.
On 04/13/2015 04:24 PM, Giacomo Vacca wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/121 Commit Summary
- ndb_redis: optionally allow mod init with redis unavailable
- ndb_redis: update doc with init_without_redis
- ndb_redis: update README with init_without_redis
File Changes
- *M* modules/ndb_redis/README
https://github.com/kamailio/kamailio/pull/121/files#diff-0 (28)
- *M* modules/ndb_redis/doc/ndb_redis_admin.xml
https://github.com/kamailio/kamailio/pull/121/files#diff-1 (19)
- *M* modules/ndb_redis/ndb_redis_mod.c
https://github.com/kamailio/kamailio/pull/121/files#diff-2 (13)
Patch Links:
- https://github.com/kamailio/kamailio/pull/121.patch
- https://github.com/kamailio/kamailio/pull/121.diff
— Reply to this email directly or view it on GitHub https://github.com/kamailio/kamailio/pull/121.
sr-dev mailing listsr-dev@lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev