28 Jan
2021
28 Jan
'21
4:21 a.m.
> @wkampich - one clarification, maybe my first
comment was confusing: there can be pull requests that change code in many modules, but it
has to contain commits per module/component. In the first version of the PR, there was a
part of the commit that changed http_client module along with the lost module.
> I wanted to say that the PR has to contain two commits, one for http_client module
and the other for the lost module. A PR is not restricted to a single commit. With the
latest commit in this PR, I see that the part for http_client is no longer present.
I created the commit in a hurry and unfortunately overlooked that lost and http_client are
combined in one commit. My attempt to fix this quickly was not really successful. As I am
currently extending the lost module for an ETSI interop. event in February, there will
probably be other additions or fixes to the current lost module branch. Maybe it is better
to close this PR and create a new one after the event to discuss the final version or get
feedback from other developers. Then I will also consider the http_client commit.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2606#issuecomment-768442771