Re: [sr-dev] [kamailio/kamailio] evapi: Added destination address on evapi_relay (#596)

There is a shm memory leak because the data is not allocated along with the evapi_relay_cmd structure. Also, the indentation seems to be done with whitespaces instead of tabs, breaking the formatting of the blocks. Thinking more of it, I think it could be rather hard to match on source IP and port for tcp connections, because the kernel may allocate random ports, even one tries to bind on a specific one. Maybe we can add sort of connection tagging (or channel name) - when the connection is open by the client app, it gives the tag/channel name. Or eventually, a new function can be exported to set the tag/channel name inside the event_route[evapi:connection-new]. The tag/channel name will be a new field in the connection structure. Then the evapi relay will match on this name rather than source ip port. What do you think? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/596#issuecomment-216663484