[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

@miconda commented on this pull request. + + if(rank == PROC_MAIN) { + if(rtpengine_dtmf_event_sock.len > 0) { + LM_DBG("Register RTPENGINE DTMF WORKER %d\n", mypid); + /* fork worker process */ + mypid = fork_process(PROC_RPC, "RTPENGINE DTMF WORKER", 1); + if(mypid < 0) { + LM_ERR("failed to fork RTPENGINE DTMF WORKER process %d\n", mypid); + return -1; + } else if(mypid == 0) { + if(cfg_child_init()) + return -1; + /* this will loop forever */ + rtpengine_dtmf_events_loop(); + } I think we do not have explicitly `exit` after the functions doing infinite loops in the special child process. But it could be a good practice to kill the process (and by that kamailio instance) if the function that should do infinite loop exits due to some errors before it enters the infinite loop. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3473#discussion_r1227023280 You are receiving this because you are subscribed to this thread. Message ID: &lt;kamailio/kamailio/pull/3473/review/1475471766(a)github.com&gt;