20 Oct
2023
20 Oct
'23
3:37 p.m.
I don't see a major difference from the point of
view of the internal variables/fields compared with the other PR #3609.
Maybe a simpler approach is to introduce a new parameter to specify what is the type
(unit) of the timeout, like `timeout_mode`, which if it is 0 (default) is going to
consider the values in seconds and if set to 1, then it is going to consider the values in
milliseconds and based on its value, the appropriate curl option is set.
I was trying to implement Olle's proposal, i.e. having only one timeout internally
(visible in the curl_con_t struct, and shown through RPC "httpclient.listcon").
Your proposal is interesting, it removes all the complexity and still allows existing
configuration to work as before. I'll look into it.
Thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3611#issuecomment-1773298282
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3611/c1773298282(a)github.com>